-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories #15046
[PublishBuildArtifactsV1] Delete hardcoded "/E" option not to copy subdirectories #15046
Conversation
…shBuildArtifacts_Recursive_copy
@tatyana-kostromskaya, @anatolybolshakov Could this be a breaking change for the customers who use this task with a current behavior? |
I discussed it with @anatolybolshakov. This behavior is not documented so we can consider these changes as bug fixing of unexpected behavior. |
…shBuildArtifacts_Recursive_copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Could you please take a look at the comments?
…shBuildArtifacts_Recursive_copy
…shBuildArtifacts_Recursive_copy
Task name: PublishBuildArtifactsV1
Description:
Delete from robocopy call hardcoded "/E" option and replace it with variable. This variable will contain "/E" option if "PathToPublish" is not a file, and it will be empty string in case "PathToPublish" is file
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) #14984
Checklist: